Use httphelper and cache response even when it is empty

[VicDeo]

Fixes #12164

[DeepDiver1975]

sure about this? previously the json response was stored

[DeepDiver1975]

change in behavior: in the previous implementation the empty array was simply returned but not stored

[VicDeo]

@DeepDiver1975 and this behavior introduces #12164

[DeepDiver1975]

I see - thx for the explanation

[DeepDiver1975]

and please squash the commits - thx

[DeepDiver1975]

unit test will fail because of:

https://scrutinizer-ci.com/g/owncloud/core/inspections/01121ffa-d3e3-4f2c-aa64-5d63ca4f2bab/issues/files/tests/lib/updater.php?status=new&orderField=path&order=asc

[VicDeo]

@DeepDiver1975 yes, I already fixed that locally, writing new tests right now

[ghost]

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3298/

Build result: FAILURE

[...truncated 18 lines...] > git rev-parse origin/pr/12437/merge^{commit} # timeout=10Checking out Revision a030bae15a820c42b7f1df7caa1b8eb5fa386a40 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a030bae15a820c42b7f1df7caa1b8eb5fa386a40 > git rev-list e6ef51c8d1fd29d898fb5cdce2ded30237996c33 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveCleaning workspace > git rev-parse --verify HEAD # timeout=10Resetting working tree > git reset --hard # timeout=10 > git clean -fdx # timeout=10 > git submodule foreach --recursive git reset --hard # timeout=10 > git submodule foreach --recursive git clean -fdx # timeout=10Triggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 second
💣 Test FAILed. 💣

[MorrisJobke]

@DeepDiver1975 The git clone error on jenkins is back :(

[VicDeo]

@owncloud-bot Do you need more RAM or HDD? 🍨

[LukasReschke]

@VicDeo Unfortunately not that easy to solve. Bug in the plugin… It's enough horse power behind it :-(

[DeepDiver1975]

@VicDeo unit tests are failing:

https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3359/label=vm-slave-02/testReport/junit/%28root%29/OC_UpdaterTest/testCheck/

Stacktrace

OC\UpdaterTest::testCheck
Undefined variable: httpHelper

/var/jenkins/workspace/pull-request-analyser-ng-simple/label/vm-slave-02/tests/lib/updater.php:36

[ghost]

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3399/

Build result: FAILURE

[...truncated 18 lines...] > git rev-parse origin/pr/12437/merge^{commit} # timeout=10Checking out Revision 23f132d1bf3dee88e92779116e3fe0841b0c5670 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 23f132d1bf3dee88e92779116e3fe0841b0c5670 > git rev-list 6bb837a7468e75147925f97d75b17e9a630c87d3 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveCleaning workspace > git rev-parse --verify HEAD # timeout=10Resetting working tree > git reset --hard # timeout=10 > git clean -fdx # timeout=10 > git submodule foreach --recursive git reset --hard # timeout=10 > git submodule foreach --recursive git clean -fdx # timeout=10Triggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second
💣 Test FAILed. 💣

[scrutinizer-notifier]

The inspection completed: 1 new issues, 1 updated code elements

[VicDeo]

will create a new branch to make Jenkins happy