Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct access versions in the web UI #7196

Closed
michaelstingl opened this issue May 20, 2019 · 7 comments
Closed

Direct access versions in the web UI #7196

michaelstingl opened this issue May 20, 2019 · 7 comments
Assignees
Labels
Enhancement p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@michaelstingl
Copy link
Contributor

This might help while #4556 isn’t designed and implemented yet.

It needs only a new entry in the context menu, that opens a private link in the default system web browser, with a special parameter at the end.

There’s also a new capability available in the 10.2.

Technical docs

@michaelstingl michaelstingl added this to the 2.6.0 milestone May 20, 2019
@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label May 29, 2019
@ckamm ckamm self-assigned this Jun 4, 2019
ckamm added a commit that referenced this issue Jun 4, 2019
The new menu entry depends on the privateLinksDetailsParam
capability of the server.
@ckamm
Copy link
Contributor

ckamm commented Jun 4, 2019

QA:

  • Verify that the new "Show file versions in browser" right-click menu item shows up when the server supports it (privateLinksDetailsParam capability)
  • That it doesn't show up for older servers.
  • That using the item opens the browser and shows the "versions" pane for the correct file/dir

ckamm added a commit that referenced this issue Jun 4, 2019
The new menu entry depends on the privateLinksDetailsParam
capability of the server.
ckamm added a commit that referenced this issue Jun 4, 2019
The new menu entry depends on the privateLinksDetailsParam
capability of the server.
@ckamm ckamm added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Jun 4, 2019
@michaelstingl
Copy link
Contributor Author

Just found folders have no versions. That would be cool to change. Sorry, my fault.

@michaelstingl
Copy link
Contributor Author

michaelstingl commented Jun 14, 2019

occ app:disable files_versions on the ownCloud server should also disable this.

occ app:enable files_versions ==>

$ curl --silent -u admin:password 'https://example.cloud/ocs/v1.php/cloud/capabilities?format=json' | json_pp
{
…
            "files" : {
               "versioning" : true,
               "privateLinksDetailsParam" : true,
               "undelete" : true,
               "privateLinks" : true,
               "blacklisted_files" : [
                  ".htaccess"
               ],
               "bigfilechunking" : true
            },

occ app:disable files_versions

$ curl --silent -u admin:password 'https://example.cloud/ocs/v1.php/cloud/capabilities?format=json' | json_pp
{
…
            "files" : {
               "undelete" : true,
               "privateLinksDetailsParam" : true,
               "privateLinks" : true,
               "blacklisted_files" : [
                  ".htaccess"
               ],
               "bigfilechunking" : true
            },

@ckamm do we check both capabilities? ( privateLinksDetailsParam AND versioning )

@ckamm ckamm removed the ReadyToTest QA, please validate the fix/enhancement label Jun 14, 2019
@ckamm
Copy link
Contributor

ckamm commented Jun 14, 2019

Good finds! No, I wasn't aware of the versioning capability and will add the check. And remove it for folders.

ckamm added a commit that referenced this issue Jun 14, 2019
- Don't show it for directories.
- Don't show it when versioning is disabled.
guruz pushed a commit that referenced this issue Jun 16, 2019
- Don't show it for directories.
- Don't show it when versioning is disabled.
@guruz guruz added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Jun 16, 2019
@guruz
Copy link
Contributor

guruz commented Jun 16, 2019

@michaelstingl Please test

@HanaGemela
Copy link
Contributor

Tested with macOS 10.14.5, client 2.6.0alpha2 (build 12128)
Option not shown for server 10.1.1 (stable)
For server 10.2.1 (Stable):
Shown for files when files_versions enabled
Not shown for folders and when files_versions disabled

Waiting for @michaelstingl if he wants to test himself. Otherwise this issue can be closed

@HanaGemela
Copy link
Contributor

QA done for this issue so I'm removing the ReadyToTest label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

4 participants