Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Format starlark #991

Merged
merged 2 commits into from
Jul 28, 2021
Merged

[tests-only] Format starlark #991

merged 2 commits into from
Jul 28, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 28, 2021 •
edited
Loading

  1. replace tab-indent with space-indent in .drone.star
  2. add check-starlark pipeline to check the formatting of the drone starlark code - the same as in owncloud/web

@phil-davis phil-davis self-assigned this Jul 28, 2021
@phil-davis phil-davis marked this pull request as ready for review July 28, 2021 12:07
@phil-davis
Copy link
Contributor Author

phil-davis commented Jul 28, 2021 •
edited
Loading

This makes the activity app have similar format .drone.star like what was done in owncloud/web#4987 and owncloud/ocis#2023

If we do this, then next time we have .drone.star changes to update through all oC10 apps I will apply this formatting change.

Is this "a good thing" ?

wkloucek
wkloucek approved these changes Jul 28, 2021
View reviewed changes
Copy link

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wkloucek
Copy link

This makes the activity app have similar format .drone.star like what was done in owncloud/web#4987 and owncloud/ocis#2023

If we do this, then next time we have .drone.star changes to update through all oC10 apps I will apply this formatting change.

Is this "a good thing" ?

First of all it's hard work to apply this on all pipelines. I have been annoyed that I can't copy functions between files and then just apply a formatter because then the whole diff is not only reflecting my changes... I would say it's a good thing to enforce a certain format like we do it for all other code, too

@phil-davis phil-davis mentioned this pull request Jul 28, 2021
Merged
11 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 339196b into master Jul 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the format-starlark branch July 28, 2021 12:47
This was referenced Jul 28, 2021
Merged
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

@wkloucek wkloucek wkloucek approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @wkloucek @xoxys