Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWL to OBO conversion error log #1091

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

hkir-dev
Copy link
Contributor

Fix for the issue on ontodev/robot#1088

When processing OWL constructs outside the OBO spec, a nasty error is generated which pollutes the Log files. This error does not affect the conversion, it just logs an error and completes the conversion successfully.

Analysis:
This error is introduced with this commit: 49eaf8d

Fix is to use an injector to get a new manager to create the ontology. A manager provider would be a better solution but there are static methods and interface changes involved.

However, while injecting a new OWLOntologyManager, this injector was unable to initialize the OWLOntologyBuilder and log an error. But in the consecutive steps, ontology factories are manually set from the source manager, so execution continues successfully.

This fix introduces a dummy OWLOntologyBuilder to the injector. By this way the OWLOntologyManager is created without error and then the dummy builder is replaced with a proper one as before.

@matentzn
Copy link

Excellent @hkir-dev, lets see if @ignazio1977 agrees this is the right way to fix ontodev/robot#1088.

@ignazio1977 don't make a new release yet after merging this, there is another major bug we do not have a a strategy for yet: ontodev/robot#1089

@ignazio1977 ignazio1977 merged commit c8f2900 into owlcs:version4 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants