Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue on ontodev/robot#1088
When processing OWL constructs outside the OBO spec, a nasty error is generated which pollutes the Log files. This error does not affect the conversion, it just logs an error and completes the conversion successfully.
Analysis:
This error is introduced with this commit: 49eaf8d
However, while injecting a new
OWLOntologyManager
, this injector was unable to initialize theOWLOntologyBuilder
and log an error. But in the consecutive steps, ontology factories are manually set from the source manager, so execution continues successfully.This fix introduces a dummy
OWLOntologyBuilder
to the injector. By this way theOWLOntologyManager
is created without error and then the dummy builder is replaced with a proper one as before.