-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jean/logging #77
base: main
Are you sure you want to change the base?
Jean/logging #77
Conversation
Hey @umarteauowkin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work! Just a minor comment, is it possible to add a piece of test for the added components?
Unfortunately we won't be able to do explicit testings. Implicit testing works to the extents that I tested all FL algorithms which produce correct graphs and tables. As the goal of this util is really for power users I don't mind that it can break if some other FL algos are developed. Monitoring is orthogonal to algorithmic functionalities which themselves should be properly tested. However I cannot merge it as it is right now because of the immense overhead it adds (CI goes up to like 4 hours). I am trying to find a way to cancel every monitoring by default so that most users don't have to face the consequences. |
… thanks to Ulysse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective (credit assignent), LGTM ! Thanks @jeandut :)
Use fed-pydeseq2 logging utils written by @umarteauowkin to log all training quantities that are exchanged in nice graphs and tables.