Feature/support custom aws endpoint #1101
Conversation
| <%#= label_tag t('camaleon_cms.admin.settings.filesystem_s3_endpoint', default: 'filesystem_s3_endpoint') %> <small>(*)</small><br> | ||
| <%#= text_field :options, :filesystem_s3_endpoint, :class => "form-control required", value: @site.get_option("filesystem_s3_endpoint"), placeholder: 's3-us-west-2.amazonaws.com' %> | ||
| </div>--> | ||
| <div class="form-group"> |
There was a problem hiding this comment.
Thanks for the PR, @graysonchen !
Let's ask first @owen2345 why the code has been commented from the very creation? Are there any obstacles to enable it?
There was a problem hiding this comment.
AFAIR, the implementation was not complete and thus I preserved the HTML part commented.
@graysonchen, not yet ready to merge - there is a lint failure, and also, a failure of the |
|
OK, I've fixed the Rubocop issue, and the remaining failure is caused by Thanks again, @graysonchen! |
No description provided.