Add larastan analyse #811
Add larastan analyse #811
Conversation
erikn69
force-pushed
the
patch-4
branch
4 times, most recently
from
fa071db to
0dd56b5
Compare
src/Drivers/Database.php
Outdated
| ->get() | ||
| ->slice($threshold) | ||
| ->pluck('id'); | ||
| ->offset($threshold)->limit((int) '18446744073709551615') |
There was a problem hiding this comment.
Ok, larastan says that we are bringing unnecessary data to memory.
Example, if we have $threshold = 1000 and audits are 1001, we brings to memory 1001 colection and slice just last one for delete, even if it is less than a 1000, the data is always brought to memory
maybe it would be better to open another PR to discuss this change, i can revert this and set an exception for phpstan
I imagine this goes for V14
Maybe changing to ->limit(PHP_INT_MAX)?
There was a problem hiding this comment.
Another better way is just delete, getting no data, nir checking for empty
return $model->audits()
->latest()
->offset($threshold)->limit(PHP_INT_MAX)
->delete() > 0;still passes the test itWillRemoveOlderAuditsAboveTheThreshold
There was a problem hiding this comment.
This change was added here (12ded01), any reason to do it like this?
|
Right. Lets get it in the branch and look at it. |
Complement of #810
Closes #808
seems like this make phpstan happy