Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing phpstan namespace issues #798

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

aglipanci
Copy link
Contributor

Class OwenIt\Auditing\Contracts\OwenIt\Auditing\Models\Audit was not found while trying to analyse it - discovering symbols is probably not configured properly.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                  

@MortenDHansen
Copy link
Contributor

Haven't seen this as an issue, but we should probably use an import of the contract to be explicit.

use OwenIt\Auditing\Contracts\Audit as AuditContract;

As @erikn69 says, we need to type to the contract. The implementation may vary

@aglipanci
Copy link
Contributor Author

Haven't seen this as an issue, but we should probably use an import of the contract to be explicit.

use OwenIt\Auditing\Contracts\Audit as AuditContract;

As @erikn69 says, we need to type to the contract. The implementation may vary

It started to show just today for me as well. I thought of a quick fix, but yeah, looking at it now it makes more sense as this is an interface.

Let me know if I should update it to that.

@aglipanci
Copy link
Contributor Author

Updated.

@anteriovieira anteriovieira merged commit fc4d72a into owen-it:master Mar 15, 2023
@anteriovieira
Copy link
Member

Thanks @aglipanci

@aglipanci
Copy link
Contributor Author

Any chance you will release a new version anytime soon?

@MortenDHansen
Copy link
Contributor

Any chance you will release a new version anytime soon?

Its tagged now :)

@digistorm-developer
Copy link

This phpstan error is still persistent in v13.5.1 - The FQN is missing a leading slash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants