🚨 audit should not have a factory

owen-it · Dec 24, 2024 · 00395fa · 00395fa
1 parent 23ff144
commit 00395fa
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 56 deletions.
diff --git a/tests/Unit/AuditTest.php b/tests/Unit/AuditTest.php
@@ -415,14 +415,18 @@ public function itReturnsAuditableModifiedAttributesAsJsonString()
      */
     public function itReturnsDecodedAuditableAttributes()
     {
-        $article = new itReturnsDecodedAuditableAttributesArticle();
+        $model = factory(Article::class)->create();
+
+        $this->assertTrue(itReturnsDecodedAuditableAttributesArticle::first()->is($model));
 
         // Audit with redacted/encoded attributes
-        $audit = factory(Audit::class)->create([
-            'auditable_type' => get_class($article),
-            'old_values'     => [
-                'title'    => 'SG93IFRvIEF1ZGl0IE1vZGVscw==',
-                'content'  => '##A',
+        $audit = Audit::create([
+            'event' => 'updated',
+            'auditable_id' => $model->getKey(),
+            'auditable_type' => itReturnsDecodedAuditableAttributesArticle::class,
+            'old_values' => [
+                'title' => 'SG93IFRvIEF1ZGl0IE1vZGVscw==',
+                'content' => '##A',
                 'reviewed' => 0,
             ],
             'new_values'     => [
@@ -456,7 +460,12 @@ public function itReturnsDecodedAuditableAttributes()
      */
     public function itReturnsTags()
     {
-        $audit = factory(Audit::class)->create([
+        $model = factory(Article::class)->create();
+
+        $audit = Audit::create([
+            'event' => 'updated',
+            'auditable_id' => $model->getKey(),
+            'auditable_type' => Article::class,
             'tags' => 'foo,bar,baz',
         ]);
 
@@ -474,7 +483,12 @@ public function itReturnsTags()
      */
     public function itReturnsEmptyTags()
     {
-        $audit = factory(Audit::class)->create([
+        $model = factory(Article::class)->create();
+
+        $audit = Audit::create([
+            'event' => 'updated',
+            'auditable_id' => $model->getKey(),
+            'auditable_type' => Article::class,
             'tags' => null,
         ]);
 
@@ -491,4 +505,4 @@ class itReturnsDecodedAuditableAttributesArticle extends Article
         'title'   => Base64Encoder::class,
         'content' => LeftRedactor::class,
     ];
-}
+}
diff --git a/tests/Unit/AuditableTest.php b/tests/Unit/AuditableTest.php
@@ -993,7 +993,7 @@ public function itFailsToTransitionWhenTheAuditAuditableTypeDoesNotMatchTheModel
         $this->expectException(AuditableTransitionException::class);
         $this->expectExceptionMessage('Expected Auditable type OwenIt\Auditing\Tests\Models\Article, got OwenIt\Auditing\Tests\Models\User instead');
 
-        $audit = factory(Audit::class)->make([
+        $audit = new Audit([
             'auditable_type' => User::class,
         ]);
 
@@ -1047,7 +1047,7 @@ public function itFailsToTransitionWhenTheAuditAuditableTypeDoesNotMatchTheMorph
             'articles' => Article::class,
         ]);
 
-        $audit = factory(Audit::class)->make([
+        $audit = new Audit([
             'auditable_type' => 'users',
         ]);
 
@@ -1085,7 +1085,8 @@ public function itFailsToTransitionWhenTheAuditAuditableIdTypeDoesNotMatchTheMod
 
         $model = factory(Article::class)->create();
 
-        $audit = factory(Audit::class)->create([
+        $audit = Audit::create([
+            'event' => 'updated',
             'auditable_type' => Article::class,
             'auditable_id'   => (string)$model->id,
         ]);
@@ -1118,7 +1119,8 @@ public function itTransitionsWhenTheAuditAuditableIdTypeDoesNotMatchTheModelIdTy
             $key = (int)$model->id;
         }
 
-        $audit = factory(Audit::class)->create([
+        $audit = Audit::create([
+            'event' => 'updated',
             'auditable_type' => Article::class,
             'auditable_id'   => $key,
         ]);
@@ -1141,8 +1143,9 @@ public function itFailsToTransitionWhenAnAttributeRedactorIsSet()
             'title' => RightRedactor::class,
         ];
 
-        $audit = factory(Audit::class)->create([
-            'auditable_id'   => $model->getKey(),
+        $audit = Audit::create([
+            'event' => 'created',
+            'auditable_id' => $model->getKey(),
             'auditable_type' => Article::class,
         ]);
 
@@ -1157,9 +1160,9 @@ public function itFailsToTransitionWhenTheAuditableAttributeCompatibilityIsNotMe
     {
         $model = factory(Article::class)->create();
 
-        $incompatibleAudit = factory(Audit::class)->create([
-            'event'          => 'created',
-            'auditable_id'   => $model->getKey(),
+        $incompatibleAudit = Audit::create([
+            'event' => 'created',
+            'auditable_id' => $model->getKey(),
             'auditable_type' => Article::class,
             'old_values'     => [],
             'new_values'     => [
@@ -1168,19 +1171,25 @@ public function itFailsToTransitionWhenTheAuditableAttributeCompatibilityIsNotMe
             ],
         ]);
 
+        $exceptionWasThrown = false;
+
         try {
             $model->transitionTo($incompatibleAudit);
         } catch (AuditableTransitionException $e) {
             $this->assertSame(
-                'Incompatibility between [OwenIt\Auditing\Tests\Models\Article:1] and [OwenIt\Auditing\Models\Audit:3]',
+                'Incompatibility between [OwenIt\Auditing\Tests\Models\Article:1] and [OwenIt\Auditing\Models\Audit:2]',
                 $e->getMessage()
             );
 
             self::Assert()::assertArraySubset([
                 'subject',
                 'text',
             ], $e->getIncompatibilities(), true);
+
+            $exceptionWasThrown = true;
         }
+
+        $this->assertTrue($exceptionWasThrown);
     }
 
     /**
@@ -1216,8 +1225,9 @@ public function itTransitionsToAnotherModelState(
         $auditableType = $morphMap ? 'articles' : Article::class;
 
         $audits = $models->map(function (Article $model) use ($auditableType, $oldValues, $newValues) {
-            return factory(Audit::class)->create([
-                'auditable_id'   => $model->getKey(),
+            return Audit::create([
+                'event' => 'updated',
+                'auditable_id' => $model->getKey(),
                 'auditable_type' => $auditableType,
                 'old_values'     => $oldValues,
                 'new_values'     => $newValues,

diff --git a/tests/database/factories/AuditFactory.php b/tests/database/factories/AuditFactory.php