Added drop action for nginx #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I think this is the right patch. Just let me know one thing. Since ModSecurity is also compiled for Apache WIN32 and in this case standalone module is not compiled (so VERSION_NGINX is not defined) I think we should remove defined(WIN32). Just using define(VERSION_NGINX). What do you think ? |
|
I agree with you. I do so because i thought WIN32 is for iis and there might be some drop hook for iss. |
brenosilva
added a commit
that referenced
this pull request
Dec 21, 2012
Added drop action for nginx
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.