Change the return type of CatalogObjectController methods #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelAudren
force-pushed
the
swagger-model
branch
3 times, most recently
from
262afe0 to
522779b
Compare
…fix issues with the swagger model
MaelAudren
force-pushed
the
swagger-model
branch
from
522779b to
5bb6ec9
Compare
marcocast
reviewed
Jan 9, 2018
| @@ -242,7 +240,7 @@ public CatalogObjectMetadataList create( | |||
| } catch (IOException ioe) { | |||
| throw new RuntimeException(ioe); | |||
| } | |||
| return ResponseEntity.status(status).build(); | |||
| return new ResponseEntity<>(status); | |||
There was a problem hiding this comment.
I prefer to use the builder .... ResponseEntity.status(status).build();
There was a problem hiding this comment.
ResponseEntity.status(status).build(); return a Response which doesn't compile due to the return Response<List>
marcocast
reviewed
Jan 9, 2018
| @@ -302,7 +300,7 @@ public CatalogObjectMetadataList create( | |||
| commitTimeRaw); | |||
| return ResponseEntity.ok(catalogObjectMetadata); | |||
| } catch (RevisionNotFoundException e) { | |||
| return ResponseEntity.notFound().build(); | |||
| return new ResponseEntity(HttpStatus.NOT_FOUND); | |||
There was a problem hiding this comment.
better with the builder no?
There was a problem hiding this comment.
same as upper response
marcocast
approved these changes
Jan 9, 2018
pedrovelho
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the return type of CatalogObjectController method in order to fix issues with the swagger model. It fix issues that prevent the generation of a usable catalog client.
It solves the swagger model issue "Not a valid ...File definition"