Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand allowed types for tableRefFor and tableNameFor #9

Merged
merged 1 commit into from
Aug 10, 2022
Merged

expand allowed types for tableRefFor and tableNameFor #9

merged 1 commit into from
Aug 10, 2022

Conversation

marcinlee
Copy link

It fixes:

TS2345: Argument of type 'ModelClass<any>' is not assignable to parameter of type 'typeof Model'.

for cases like:

query.tableRefFor(query.modelClass());

@marcinlee marcinlee self-assigned this Aug 9, 2022
@marcinlee @falkenhawk
expand allowed types for tableRefFor and tableNameFor
41ae715 
it fixes:
Argument of type 'ModelClass<Foo>' is not assignable to parameter of type 'typeof Model'
@falkenhawk falkenhawk changed the base branch from v3-mod-allow-type-override to master August 10, 2022 08:32
@falkenhawk falkenhawk merged commit f5a7133 into master Aug 10, 2022
@falkenhawk falkenhawk mentioned this pull request Apr 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkenhawk falkenhawk falkenhawk approved these changes

@flipace flipace flipace approved these changes

Assignees

@marcinlee marcinlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinlee @flipace @falkenhawk