-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sqlite3 to dbfixtures executor #613
Conversation
f4a6180
to
b01e50a
Compare
CDS Report build-venom-a#1061.0 ✘
|
Hello, unit tests:
integration tests:
you can also give a try to gitpod https://www.gitpod.io/ https://github.com/ovh/venom/blob/master/.gitpod.yml i run the tests in our CI and it is failing |
Signed-off-by: Elias Tandel <elias.tandel@90poe.io>
107307c
to
4ae6b48
Compare
Signed-off-by: Elias Tandel <elias.tandel@90poe.io>
4ae6b48
to
e7de020
Compare
Hi @fsamin, thanks a lot for the review and the additional instructions on running the integration tests. I just pushed some fixes and I also took the liberty of adding your testing instructions to the main README under the |
Co-authored-by: François Samin <francois.samin+github@gmail.com> Signed-off-by: Elias Tandel <elias.tandel@90poe.io>
8cfff4c
to
95d2442
Compare
LGTM |
LGTM, thank you @etandel |
Thanks everyone! |
It seems the underlying libraries used by
dbfixtures
support sqlite3, so I'm adding support for it as well.I think the tests are passing locally, that's why I'm opening this PR, but TBH I'm not completely sure:
make integration-test
exits successfully with0
, but I don't see any venom output in my stdout.Do let me know if anything else needs changing.