refactor(executor): rewrite whole imap executor to add new commands #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomadele
force-pushed
the
refactor-imap-executor
branch
from
06a926b to
0c7c1fc
Compare
|
Having troubles with signed commits, will check later. |
tomadele
force-pushed
the
refactor-imap-executor
branch
4 times, most recently
from
1682518 to
0ab93fc
Compare
benoitmasson
reviewed
Dec 1, 2022
benoitmasson
reviewed
Dec 1, 2022
benoitmasson
reviewed
Dec 1, 2022
benoitmasson
reviewed
Dec 1, 2022
yesnault
requested changes
Dec 6, 2022
| searchsubject: Title .* | ||
| assertions: | ||
| - result.err ShouldNotBeNil | ||
| - name: Clear a mailbox |
There was a problem hiding this comment.
Can you keep a step sending a mail with smtp executor (and fetch by imap exec) please?
tomadele
force-pushed
the
refactor-imap-executor
branch
from
75be8e6 to
32d46c4
Compare
tomadele
force-pushed
the
refactor-imap-executor
branch
from
88f2e8f to
37e452c
Compare
|
CDS Report build-venom-a#1058.0 ✘
|
|
CDS Report build-venom-a#1059.0 ✘
|
yesnault
approved these changes
Dec 21, 2022
…append, create, clear, delete, fetch, flag and move) Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com>
…o SMTP tests Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com>
…update doc Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com>
Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com>
tomadele
force-pushed
the
refactor-imap-executor
branch
from
9bffbe4 to
9a4b275
Compare
fsamin
approved these changes
Dec 29, 2022
|
LGTM, thank you @tomadele |
ivan-velasco
pushed a commit
to socotra/venom
that referenced
this pull request
Sep 20, 2023
…vh#611) * refactor(executor): rewrite whole imap executor to add new commands (append, create, clear, delete, fetch, flag and move) Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com> * refactor(): change IMAP/SMTP docker image + add mail retrieval test to SMTP tests Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com> * refactor(imap): rollback to regex search criteria + fix some tests + update doc Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com> * tests(smtp): add retries to SMTP 'IMAP - Retrieve sent mail' test case Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com> --------- Signed-off-by: Tom ADELE <tom.adele@ovhcloud.com> Co-authored-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commands: append, create, clear, delete, fetch, flag, move