-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detailed steps output #487
Conversation
Hello @lowlighter, Thanks for this improvement. IMHO, we should be careful with display of variables directly in the output because they can contain sensitive informations. |
dac49b2
to
ec5daf8
Compare
This comment has been minimized.
This comment has been minimized.
I changed it to only display the only the range key instead. The value output is good in theory, but it can be very long and break the whole output in addition of the issue you mentioned (though I think that looping over secrets is a probably idea in the start) |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: GitHub <noreply@github.com>
146e886
to
78e2d26
Compare
This comment has been minimized.
This comment has been minimized.
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: GitHub <noreply@github.com>
72443c5
to
0f2bc2a
Compare
CDS Report build-venom-a#892.0 ✘
|
Signed-off-by: GitHub <noreply@github.com>
Kudos, SonarCloud Quality Gate passed! |
Closes #485
This is a followup of #453
This PR introduces a detailed output:
range
are expanded and display current key for easier loop trackingMust
failed assertions display the number of skipped stepsAlso fix some issues:
range
step dump were overwritten because they had the same namerange
exited the range loop rather than fallthrough (default behaviour of steps)-v
and `` had actually the same verbosity levelPreview (
![image](https://user-images.githubusercontent.com/22963968/149851265-1034ca3e-a5b1-4d6e-a9c6-8f27459c7154.png)
-v
output):Preview (default output):
![image](https://user-images.githubusercontent.com/22963968/149852516-585f8016-6cfa-411d-b2c6-4e0d1634aadf.png)