Improve linter configuration #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Moscon <mosconfabrizio@gmail.com>
fabriziomoscon
force-pushed
the
fix/linter
branch
from
e1cedc8 to
b29b045
Compare
|
Thank you. Another PR to fix errors will be welcome (and we could add lint in our ci) |
yesnault
approved these changes
Dec 9, 2021
fsamin
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted the initial use of linting, so here is an update with some improvements that 90poe has implemented internally.
There are a lot of linting errors, if you agree to add
make lintas part of CI, I could work on PR to fix those errors.Let me know.