Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation update for beta4 #763

Closed
miklosbagi opened this issue Jan 25, 2024 · 4 comments
Closed

Documentation update for beta4 #763

miklosbagi opened this issue Jan 25, 2024 · 4 comments

Comments

@miklosbagi
Copy link
Contributor

Howdy folks,

I looked up the docs for SQL executor and ran into having __len__ provided as example for assertions, which I believe is now __Len__, here: README.md

HTH,
mb
@ivan-velasco
Copy link
Contributor

That is correct or you can use ShouldHaveLength

@miklosbagi
Copy link
Contributor Author

Hey @ivan-velasco, thanks for your reply.

So this is the case now, correct?

  • __len__ fails
  • __Len__ works
  • ShouldHaveLength works

miklosbagi pushed a commit to miklosbagi/venom that referenced this issue Jan 26, 2024
Update examples for queries length assert ovh#763
6c5f5a8
miklosbagi pushed a commit to miklosbagi/venom that referenced this issue Jan 26, 2024
Update examples for queries length assert ovh#763
d87c861 
Signed-off-by: Miklos Bagi <mb_github@mbag.at>
miklosbagi pushed a commit to miklosbagi/venom that referenced this issue Jan 26, 2024
Update examples for queries length assert ovh#763
3b3d70e 
Signed-off-by: Miklos Bagi <mb_mbgithub@mbag.at>
miklosbagi pushed a commit to miklosbagi/venom that referenced this issue Jan 26, 2024
Update examples for queries length assert ovh#763
96dc8e0 
Signed-off-by: Miklos Bagi <mb_mbgithub@mbag.at>
Signed-off-by: Miklos Bagi <mb@localhost>
miklosbagi added a commit to miklosbagi/venom that referenced this issue Jan 26, 2024
@miklosbagi
Update examples for queries length assert ovh#763
281d23d
miklosbagi added a commit to miklosbagi/venom that referenced this issue Jan 26, 2024
@miklosbagi
Update examples for queries length assert ovh#763
edaab6b 
Signed-off-by: Miklos Bagi <mb_mbgithub@mbag.at>
@miklosbagi
Copy link
Contributor Author

Ah the commit sign... :)
Proposed update in #765

yesnault pushed a commit that referenced this issue Feb 1, 2024
@miklosbagi
Update examples for queries length assert #763 (#765)
a6549bb 
Signed-off-by: Miklos Bagi <mb_mbgithub@mbag.at>
@yesnault
Copy link
Member

yesnault commented Feb 1, 2024

merged

@yesnault yesnault closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yesnault @miklosbagi @ivan-velasco