Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

fix (groups): send error 400 instead of 500 if user does not exist #75

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

maximecaruchet
Copy link
Contributor

No description provided.

Copy link

@FabienM FabienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a 401?

@maximecaruchet
Copy link
Contributor Author

This is not an authentication problem: the user is authenticated but he is trying to add people who are not registered in TaT, which is an error from the client because the client should add existing user to groups.
That is why I chose a 400, are you OK with that or do you think another status code would be more appropriate?

@FabienM
Copy link

FabienM commented Oct 10, 2018

That is why I chose a 400, are you OK with that or do you think another status code would be more appropriate?

400 is fine 👌

@maximecaruchet maximecaruchet merged commit df70ed5 into master Oct 10, 2018
@maximecaruchet maximecaruchet deleted the fix/error-400-group-user-existence branch October 10, 2018 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants