-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Vue.js example #28
base: master
Are you sure you want to change the base?
Conversation
@elivlo Hi! Thanks for your contribution! A React, Angular, and View versions are on our roadmap, but as it's a "lower" priority, it takes time to get into it, so a contribution like yours can help implement and achieve these goals!
|
Hi @eransharv! Yes, I noticed that Vue.js example but since it is over one year old I decided to make a newer version.
To summarize, I have a few proposals:
|
@elivlo Hey, OK, now it's clearer, and it sounds good. I will forward it to the R&D for review (As they are busy, that can take some time). Basically, as I mentioned, I want to make sure that it fits our standards, as I want to include this in this "official" repo and not in the "community" repo. Can you please clarify what do you mean by "Make this example a real example"? The Vue version of the sample app must have the same functionality as the ts and native versions. No different features or UI - the only thing that should be different is the adjustments to Vue. The whole point is to show the same app in different "flavors" - Vue, React, etc. Having said that, it's ok to depend on our "official" npm packages like the "types," or make use of the Vuetify, etc. I hope that it's clear and makes sense. |
With "Make this example a real example" I meant that the vue example app is not ready to deliver the same features as the native and ts sample apps do. So I will implement all the basic example app features and then remove the "draft" from this PR. |
@elivlo thanks. We will review it, and I will update you here. That might take some time. Thanks for your contribution! |
232fb73
to
8c04d27
Compare
4bf529c
to
7e76e43
Compare
ACK |
@elivlo Thanks! Appriciated! We will review it (some of the team are on Aug. holiday, so that might take longer than usual. But we are on it). Thanks! |
@eransharv are any of them back from their holiday 3 years ago yet? 😜 It would be great if they could also take a look at #51 and #53 |
Hi 😃,
I was surprised that there was no Vue.js example. So I created a basic frame/example that should help creating Vue.js overwolf apps.