Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade_from_maple issue #692

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

ibrmora
Copy link
Contributor

@ibrmora ibrmora commented Jun 12, 2022

fix: Migration needed before upgrade_from_maple issue #689

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Could you please add an entry to the Changelog? https://docs.tutor.overhang.io/tutor.html#contributing

ibrmora added a commit to ibrmora/tutor that referenced this pull request Jun 13, 2022
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please rebase and squash your changes and we'll be ready to merge.

@regisb
Copy link
Contributor

regisb commented Jun 13, 2022

Also, please run make format to reformat your code and fix the broken test.

@ibrmora ibrmora force-pushed the upgrade-from-maple-issue branch 2 times, most recently from 4648fe2 to 7c84719 Compare June 13, 2022 16:32
fix: Migration needed before upgrade_from_maple issue overhangio#689
@regisb regisb merged commit e57e6cb into overhangio:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants