Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove trailing slash from PUBLIC_PATH env var #154

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: remove trailing slash from PUBLIC_PATH env var #154

merged 1 commit into from
Oct 3, 2023

Commits on Oct 3, 2023

  1. fix: remove trailing slash from PUBLIC_PATH env var 

    We previously generated the PUBLIC_PATH base for each MFE with a
trailing slash, e.g. "/authn/". But the actual links that point to
these from the LMS and Studio don't have a trailing slash in them,
e.g. "/authn". This commit removes the trailing slash to be consistent.
Removing that trailing slash in configuration also means that we don't
have to strip it out on the JavaScript side of things, which would have
been necessary after the React Router 6 upgrade (we send it as the
router's basename).
    @ormsbee
    ormsbee committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    2dce48d View commit details
    Browse the repository at this point in the history