-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: point ecommerce/ecommerce-worker giturls to openedx github org #79
fix: point ecommerce/ecommerce-worker giturls to openedx github org #79
Conversation
<!-- | ||
Create a changelog entry for every new user-facing change. Please respect the following instructions: | ||
- Indicate breaking changes by prepending an explosion 💥 character. | ||
- Prefix your changes with either [Bugfix], [Improvement], [Feature], [Security], [Deprecation]. | ||
- You may optionally append "(by @<author>)" at the end of the line, where "<author>" is either one (just one) | ||
of your GitHub username, real name or affiliated organization. These affiliations will be displayed in | ||
the release notes for every release. | ||
--> | ||
|
||
<!-- - 💥[Feature] Foobarize the blorginator. This breaks plugins by renaming the `FOO_DO` filter to `BAR_DO`. (by @regisb) --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Please remove these comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
--> | ||
|
||
<!-- - 💥[Feature] Foobarize the blorginator. This breaks plugins by renaming the `FOO_DO` filter to `BAR_DO`. (by @regisb) --> | ||
[Improvement] - Change ecommerce and ecommerce-worker remotes from `edx` to `openedx`. (by @christopappas) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Improvement] Change ecommerce and ecommerce-worker remotes from
edx
toopenedx
. (by @christopappas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the "-" following [Improvement]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"-" will come before [Improvement].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 👍
2926316
to
0da82ad
Compare
0da82ad
to
0540848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2U is not currently forking ecommerce/ecommerce-worker back to the edX github org, but I wanted to make this change now as to not forget later should the a fork be made.