This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
feat: add codejail with olive support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
suggested changes
Oct 26, 2022
ghassanmas
reviewed
Oct 26, 2022
|
You're both right! thanks @regisb @ghassanmas |
regisb
reviewed
Oct 28, 2022
.github/workflows/deploy.yml
Outdated
| @@ -76,7 +77,7 @@ jobs: | |||
| " | |||
| # Configure | |||
| - name: Enable plugins | |||
| run: $SSH "$TUTOR plugins enable mfe indigo android forum" | |||
| run: $SSH "$TUTOR plugins enable mfe indigo android forum codejail" | |||
There was a problem hiding this comment.
Don't we have to run tutor local init --limit=codejail prior to local launch, as per the codejail readme? https://github.com/eduNEXT/tutor-contrib-codejail/#usage
There was a problem hiding this comment.
After I manually installed and enabled the plugin I can confirm that init is required.
mariajgrimaldi
requested review from
regisb and
ghassanmas
and removed request for
regisb and
ghassanmas
regisb
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tutor-contrib-codejail plugin, so loncapa problems work as expected in the sandbox installation. There's already a 15.0.0 codejail image published in our dockerhub repo.
Here is the PR adding support for olive: eduNEXT/tutor-contrib-codejail#28