-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: package manager #42
Conversation
xhyrom
commented
Nov 26, 2023
•
edited
Loading
edited
- tests
I'll merge it yesterday, want to do better tests in GH action |
Thanks, Please implement this at the same time, two birds one stone ;) because it is split on And Im a bit unsure if removing the default will just make it work, I think keeping the default but using the fix I proposed in #40 is better as it still works without specifying a version anywhere |
👍🏾 Also, removing default value should work, that's how @actions/core works https://github.com/actions/toolkit/blob/master/packages/core/src/core.ts#L71 but I'll implement better tests before merging |