feat: Add async support to Bun.serve onError #8233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKastern
commented
Jan 17, 2024
| ) void { | ||
| var vm = ctx.server.vm; | ||
|
|
||
| switch (promise.status(vm.global.vm())) { |
There was a problem hiding this comment.
This is a copy of what RequestContext.onResponse is doing. I'm not sure if this is the correct way of handling the promise.
LukasKastern
commented
Jan 17, 2024
| { | ||
| ctx.flags.is_error_promise_pending = true; | ||
| ctx.pending_promises_for_abort += 1; | ||
| promise_js.then( |
There was a problem hiding this comment.
I added new callbacks for the error resolve/reject but realized that using onResolve / onError is working fine due to the deduplication check in runErrorHandlerWithStatusCodeDontCheckResponded.
|
Many many thanks again @LukasKastern Vielen Dank 😄 |
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 1, 2024
* WIP * Support not immediately fullfilled promises * Typo * Add tests * Fix test * Rename test * Remove file * [autofix.ci] apply automated fixes --------- Co-authored-by: Jarred Sumner <jarred@jarredsumner.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle promise returned from onError.
Fixes: #8217
How did you verify your code works?
I wrote automated tests