Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use options.fd if provided for fs.Read/WriteStream #4378

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Aug 28, 2023

What does this PR do?

Allows fd to be used when creating fs.ReadStream and fs.WriteStream. Also includes a fix for @clack/prompts.

fixes #3099

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

added tests.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

@dylan-conway 6 files with test failures on bun-darwin-aarch64:

  • test/bundler/esbuild/extra.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watch.test.ts

View test output

#f813513a2d29802cbcd2baf5ed66ed2e828feb67

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

✅ test failures on linux-x64-baseline have been resolved.

#f813513a2d29802cbcd2baf5ed66ed2e828feb67

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

✅ test failures on linux-x64 have been resolved.

#f813513a2d29802cbcd2baf5ed66ed2e828feb67

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

@dylan-conway 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/filesink.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/fetch/body-stream.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#f813513a2d29802cbcd2baf5ed66ed2e828feb67

src/js/node/fs.js Outdated Show resolved Hide resolved
src/js/node/fs.js Outdated Show resolved Hide resolved
src/js/node/fs.js Outdated Show resolved Hide resolved
src/js/node/fs.js Outdated Show resolved Hide resolved
@Jarred-Sumner Jarred-Sumner merged commit d1c2d6b into main Aug 29, 2023
16 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/use-fd branch August 29, 2023 03:08
@Jarred-Sumner
Copy link
Collaborator

Thank you

aMediocreDad added a commit to aMediocreDad/forbidden-lands-foundry-vtt that referenced this pull request Sep 1, 2023
oven-sh/bun#4378 fixed issue causing CI to fail when running changeset
aMediocreDad added a commit to aMediocreDad/forbidden-lands-foundry-vtt that referenced this pull request Sep 1, 2023
oven-sh/bun#4378 fixed issue causing CI to fail when running changeset
aMediocreDad added a commit to aMediocreDad/forbidden-lands-foundry-vtt that referenced this pull request Sep 1, 2023
oven-sh/bun#4378 fixed issue causing CI to fail when running changeset
aMediocreDad added a commit to aMediocreDad/forbidden-lands-foundry-vtt that referenced this pull request Sep 1, 2023
oven-sh/bun#4378 fixed issue causing CI to fail when running changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@clack/prompts module is not working
2 participants