Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path.normalize edge case. #4042

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

Hanaasagi
Copy link
Collaborator

@Hanaasagi Hanaasagi commented Aug 7, 2023

Close: #4041

What does this PR do?

path.normalize(""): If the path is a zero-length string, '.' is returned, representing the current working directory.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I or my editor ran zig fmt on the changed files
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed

@Jarred-Sumner Jarred-Sumner merged commit 5ce393a into oven-sh:main Aug 7, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path.normalize should return . when argument is empty string.
2 participants