Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4001 #4034

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Fixes #4001 #4034

merged 3 commits into from
Aug 7, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Fixes #4001

Small performance hit, but it seems there was a larger performance hit between v0.6.1 and v0.7.1 and that should be investigated.

How did you verify your code works?

There is a test

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

@Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js

View test output

#005ed298d1ba618b72ab9c606e21dbf675df9df4

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

@Jarred-Sumner 1 files with test failures on linux-x64:

  • test/js/third_party/prisma/prisma.test.ts

View test output

#005ed298d1ba618b72ab9c606e21dbf675df9df4

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

@Jarred-Sumner 1 files with test failures on linux-x64-baseline:

  • test/js/third_party/prisma/prisma.test.ts

View test output

#005ed298d1ba618b72ab9c606e21dbf675df9df4

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

@Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#005ed298d1ba618b72ab9c606e21dbf675df9df4

@Jarred-Sumner Jarred-Sumner merged commit 00a907c into main Aug 7, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/fixes-4001 branch August 7, 2023 05:49
trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
* Avoid a utf8 conversion in isDetached

* Fixes oven-sh#4001

* hit the long url codepath

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incoming Request's URL should be normalized
1 participant