Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer.copy should ignore out-of-range sourceEnd #3971

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Buffer.copy should ignore out-of-range sourceEnd #3971

merged 1 commit into from
Aug 4, 2023
+34 −17

Conversation

buffaybu
Copy link
Contributor

@buffaybu buffaybu commented Aug 4, 2023

What does this PR do?

fixes #3947

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

@Jarred-Sumner Jarred-Sumner merged commit bdbc21f into oven-sh:main Aug 4, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you!

trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
@buffaybu @trnxdev
Buffer.copy should ignore out-of-range sourceEnd (oven-sh#3971)
9573014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer.copy return value is wrong when sourceEnd is greater than actual length.
2 participants
@buffaybu @Jarred-Sumner