Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch) clean declare structs #3929

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix(fetch) clean declare structs #3929

merged 1 commit into from
Aug 2, 2023

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Aug 2, 2023

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Run #3862 test on release build with Bun.gc(true) before fetching

Fix: #3862

@cirospaciari cirospaciari changed the title clean declare structs fix(fetch) clean declare structs Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

@cirospaciari 5 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_browser.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/stubs.test.js

View test output

#0823e4c99a5d282acaa2a27018b5d46dd279fb2f

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

@cirospaciari 3 files with test failures on linux-x64:

  • test/bundler/bundler_browser.test.ts
  • test/js/node/stubs.test.js
  • test/js/third_party/prisma/prisma.test.ts

View test output

#0823e4c99a5d282acaa2a27018b5d46dd279fb2f

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

@cirospaciari 2 files with test failures on linux-x64-baseline:

  • test/bundler/bundler_browser.test.ts
  • test/js/node/stubs.test.js

View test output

#0823e4c99a5d282acaa2a27018b5d46dd279fb2f

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

@cirospaciari 6 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/bundler_browser.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/stubs.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#0823e4c99a5d282acaa2a27018b5d46dd279fb2f

@Jarred-Sumner
Copy link
Collaborator

Very strange that this fixes anything at all

@Jarred-Sumner Jarred-Sumner merged commit d9f162f into main Aug 2, 2023
@Jarred-Sumner Jarred-Sumner deleted the ciro/patch-fetch branch August 2, 2023 19:58
trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*Regression* Segmentation fault when using Bun.spawn and fetch
2 participants