Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat largefile test #3870

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Stat largefile test #3870

merged 2 commits into from
Jul 29, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Jul 29, 2023

What does this PR do?

Add a test for #3868 and #849

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

ran the test locally

lets see if github actions is okay with writing a 5 GB file to disk

@github-actions
Copy link
Contributor

@Jarred-Sumner 1 files with test failures on linux-x64-baseline:

  • test/js/node/child_process/child_process-node.test.js

View test output

#1b252c58babe9b3596ff8e46ab02eb98b94de05f

@github-actions
Copy link
Contributor

@Jarred-Sumner 1 files with test failures on linux-x64:

  • test/js/node/child_process/child_process-node.test.js

View test output

#1b252c58babe9b3596ff8e46ab02eb98b94de05f

@Jarred-Sumner Jarred-Sumner merged commit 05716ff into main Jul 29, 2023
@Jarred-Sumner Jarred-Sumner deleted the stat-largefile-test branch July 29, 2023 01:55
@github-actions
Copy link
Contributor

@Jarred-Sumner 6 files with test failures on bun-darwin-aarch64:

  • test/cli/run/log-test.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/third_party/socket.io/socket.io-middleware.test.ts

View test output

#1b252c58babe9b3596ff8e46ab02eb98b94de05f

trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
* Add test for stat on a large file

* Update fs.test.ts

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant