Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tls) exposes native canonicalizeIP and fix rootCertificates #3866

Merged
merged 9 commits into from
Jul 28, 2023
Merged

fix(tls) exposes native canonicalizeIP and fix rootCertificates #3866

merged 9 commits into from
Jul 28, 2023
+126 −30

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Jul 28, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

❌ @cirospaciari 4 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-add.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/expect.test.js
  • test/js/bun/test/test-test.test.ts

View test output

#0071fd50ddb56b37ccca142d40c027c481bdfc70

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

❌ @cirospaciari 1 files with test failures on linux-x64:

  • test/js/node/child_process/child_process-node.test.js

View test output

#0071fd50ddb56b37ccca142d40c027c481bdfc70

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

❌ @cirospaciari 1 files with test failures on linux-x64-baseline:

  • test/js/node/child_process/child_process-node.test.js

View test output

#0071fd50ddb56b37ccca142d40c027c481bdfc70

@cirospaciari cirospaciari changed the title feat(tls.canonicalizeIP) exposes native canonicalizeIP fix(tls) exposes native canonicalizeIP and fix rootCertificates Jul 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

❌ @cirospaciari 5 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/streams/streams.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#0071fd50ddb56b37ccca142d40c027c481bdfc70

@Jarred-Sumner
Copy link
Collaborator

uWebSockets PR says there’s a conflict

@cirospaciari
Copy link
Member Author

uWebSockets PR says there’s a conflict

solved

@Jarred-Sumner Jarred-Sumner merged commit e7c80b9 into main Jul 28, 2023
@Jarred-Sumner Jarred-Sumner deleted the ciro/canonicalizeIP branch July 28, 2023 22:43
@Jarred-Sumner
Copy link
Collaborator

Thank you

trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
@cirospaciari @trnxdev
fix(tls) exposes native canonicalizeIP and fix rootCertificates (oven…
23f0072 
…-sh#3866)

* exposes native canonicalizeIP

* remove unintended duplicate

* add tests

* add tests for debug builds

* add rootCertificates test and fix len

* just randomize test ids on prisma

* remove work around and bump usockets with the actual fix

* fix case

* bump uws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cirospaciari @Jarred-Sumner