Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageChannel and MessagePort #3860

Merged
merged 13 commits into from
Jul 28, 2023
Merged

Conversation

dylan-conway
Copy link
Member

@dylan-conway dylan-conway commented Jul 28, 2023

What does this PR do?

this pr implements MessageChannel and MessagePort

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote some tests for transferring message ports between message channels and across threads with Worker.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

@dylan-conway 3 files with test failures on linux-x64-baseline:

  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/child_process/child_process.test.ts
  • test/js/node/readline/readline.node.test.ts

View test output

#be235a11461ce935c4b672246b9ac904f91e2f66

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

@dylan-conway 3 files with test failures on linux-x64:

  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/child_process/child_process.test.ts
  • test/js/node/readline/readline.node.test.ts

View test output

#be235a11461ce935c4b672246b9ac904f91e2f66

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

@dylan-conway 7 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/child_process/child_process.test.ts
  • test/js/node/readline/readline.node.test.ts

View test output

#be235a11461ce935c4b672246b9ac904f91e2f66

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

@dylan-conway 8 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/child_process/child_process.test.ts
  • test/js/node/readline/readline.node.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#be235a11461ce935c4b672246b9ac904f91e2f66

@Jarred-Sumner Jarred-Sumner merged commit d614fdf into main Jul 28, 2023
@Jarred-Sumner Jarred-Sumner deleted the dylan/message-channel-and-friends branch July 28, 2023 23:44
trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
* copy and format

* copy

* copy

* cleanup

* some tests

* spellcheck

* add types

* don't lock getting contextId

* array buffer test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants