Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make readdir() async, fix crash in large directory trees #3838

Merged
merged 8 commits into from
Jul 27, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

✅ test failures on linux-x64-baseline have been resolved.

#c4538823d85b4395ae2279395ab348ae9e8c4bfd

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

@Jarred-Sumner 2 files with test failures on linux-x64:

  • test/bundler/esbuild/splitting.test.ts
  • test/js/bun/http/serve.test.ts

View test output

#c4538823d85b4395ae2279395ab348ae9e8c4bfd

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

@Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

  • test/bundler/esbuild/splitting.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts

View test output

#c4538823d85b4395ae2279395ab348ae9e8c4bfd

@Jarred-Sumner Jarred-Sumner merged commit 704ee13 into main Jul 27, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/more-reliable-fs branch July 27, 2023 11:27
@github-actions
Copy link
Contributor

@Jarred-Sumner 4 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#c4538823d85b4395ae2279395ab348ae9e8c4bfd

trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
* Fix unsafe GC behavior on large arrays returned by fs

* Fix crash in large arrays of strings

* async readdir

* Add tests for large number of files returned by readdir

* Move this down

* Fix encoding edgecase in path.join

* Async stat & lstat

* add test

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant