Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process signal events #3569

Merged
merged 25 commits into from
Jul 11, 2023
Merged

process signal events #3569

merged 25 commits into from
Jul 11, 2023

Conversation

dylan-conway
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023 •
edited
Loading

❌ @dylan-conway 7 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_compile.test.ts
  • test/cli/install/bun-run.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#214fe90cda4d2e24c66ef66de0ee44d6bfc5d8ae

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023 •
edited
Loading

❌ @dylan-conway 11 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/bundler_compile.test.ts
  • test/bundler/bundler_npm.test.ts
  • test/cli/install/bun-run.test.ts
  • test/js/bun/http/serve.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/sleepSync.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setInterval.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#214fe90cda4d2e24c66ef66de0ee44d6bfc5d8ae

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023 •
edited
Loading

❌ @dylan-conway 4 files with test failures on linux-x64-baseline:

  • test/bundler/bundler_compile.test.ts
  • test/cli/install/bun-run.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#214fe90cda4d2e24c66ef66de0ee44d6bfc5d8ae

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023 •
edited
Loading

❌ @dylan-conway 3 files with test failures on linux-x64:

  • test/cli/install/bun-run.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#214fe90cda4d2e24c66ef66de0ee44d6bfc5d8ae

@Jarred-Sumner Jarred-Sumner merged commit 5c8726d into main Jul 11, 2023
14 of 19 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/process-signal-events branch July 11, 2023 19:48
Jarred-Sumner added a commit that referenced this pull request Jul 13, 2023
@dylan-conway @Jarred-Sumner
process signal events (#3569)
96cad48 
* signal events

* simple tests

* ignore SIGSTOP

* better tests

* use `EventEmitter`

* use `Bun__getDefaultGlobal`

* progress

* don't use 'Bun__getDefaultGlobal`

* fix tests

* remove signals from map

* update tests

* don't overwrite event emitter methods

* avoid two lookups

* use `std::once`

* releaseEarly()

* Remove signal handler after use

* Update call-raise.js

* Create process-signal-handler.fixture.js

* Don't register duplicates

* Add missing lock

* another test

* update test

* revert some changes

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
@Neo00007 Neo00007 mentioned this pull request Mar 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylan-conway @Jarred-Sumner