Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of fixes #3516

Merged
merged 23 commits into from
Aug 3, 2023
Merged

Bunch of fixes #3516

merged 23 commits into from
Aug 3, 2023

Conversation

Electroid
Copy link
Contributor

@Electroid Electroid commented Jul 4, 2023

utf-8-validate is a popular package to validate utf-8, mostly because ws recommends that developers use it.

Node.js has since introduced the isUtf8 function on node:buffer. This PR makes utf-8-validate use the built-in function, to avoid potential bugs and issues with the package

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

prettier errors have been resolved. Thank you.

#ca2013b4fbbe6273b83f6d54d67d786bd7b52490

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@Jarred-Sumner 2 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_browser.test.ts
  • test/js/bun/test/test-test.test.ts

View test output

#ca2013b4fbbe6273b83f6d54d67d786bd7b52490

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@Jarred-Sumner 3 files with test failures on linux-x64:

  • test/bundler/bundler_browser.test.ts
  • test/js/node/async_hooks/AsyncLocalStorage.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#ca2013b4fbbe6273b83f6d54d67d786bd7b52490

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@Jarred-Sumner 3 files with test failures on linux-x64-baseline:

  • test/bundler/bundler_browser.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/web/fetch/fetch.test.ts

View test output

#ca2013b4fbbe6273b83f6d54d67d786bd7b52490

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@Jarred-Sumner 6 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/bundler_browser.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/process/process.test.js
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#d5d550bd5a87888cb8e838d596f568e40f2e1bfa

@Jarred-Sumner
Copy link
Collaborator

This looks good but the version of utf-8-validate should not be ^range, it should be exact (as well as types). That’s why the package-json-lint test is failing

@Jarred-Sumner
Copy link
Collaborator

Also we don’t actually need to have that package in dependencies since it will not be used

@Electroid Electroid changed the title Fix #3497 Fix utf-8-validate Jul 10, 2023
@Electroid Electroid removed the ready label Jul 23, 2023
@Jarred-Sumner Jarred-Sumner changed the title Fix utf-8-validate Bunch of fixes Aug 3, 2023
@Jarred-Sumner Jarred-Sumner merged commit 08cf0d5 into main Aug 3, 2023
@Jarred-Sumner Jarred-Sumner deleted the utf-8-validate branch August 3, 2023 22:31
trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
* Fix oven-sh#3497

* Fix oven-sh#3497

* Run prettier

* Fix package.json

* remove this too

* yeah

* Fix missing tests

* Use native for utf-8-validate

* Add module ID names to builtins

* Defer evaluation of ESM & CJS modules until link time

* Use builtin name for exports in plugins

* Add module IDs to builtins

* Update JSC build with new flag

* WebKit upgrade fixes

* Update WebKit

* prettier

* Upgrade WebKit

* bump

* Update once again

* Add visitAdditionalChildren, remove .fill() usage

* Update process.test.js

* Update fs.test.ts

---------

Co-authored-by: dave caruso <me@paperdave.net>
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utf-8-validate doesn't work with bun install due to not running postinstall script
3 participants