-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunch of fixes #3516
Bunch of fixes #3516
Conversation
✅ |
❌ @Jarred-Sumner 2 files with test failures on bun-darwin-aarch64:
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64:
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64-baseline:
|
❌ @Jarred-Sumner 6 files with test failures on bun-darwin-x64-baseline:
|
This looks good but the version of utf-8-validate should not be ^range, it should be exact (as well as types). That’s why the package-json-lint test is failing |
Also we don’t actually need to have that package in dependencies since it will not be used |
c9bac3f
to
2eae10e
Compare
2eae10e
to
dbd0a71
Compare
* Fix oven-sh#3497 * Fix oven-sh#3497 * Run prettier * Fix package.json * remove this too * yeah * Fix missing tests * Use native for utf-8-validate * Add module ID names to builtins * Defer evaluation of ESM & CJS modules until link time * Use builtin name for exports in plugins * Add module IDs to builtins * Update JSC build with new flag * WebKit upgrade fixes * Update WebKit * prettier * Upgrade WebKit * bump * Update once again * Add visitAdditionalChildren, remove .fill() usage * Update process.test.js * Update fs.test.ts --------- Co-authored-by: dave caruso <me@paperdave.net> Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
utf-8-validate
is a popular package to validate utf-8, mostly becausews
recommends that developers use it.Node.js has since introduced the
isUtf8
function onnode:buffer
. This PR makes utf-8-validate use the built-in function, to avoid potential bugs and issues with the package