Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix Fetch and WebSocket handshake #2624

Closed
wants to merge 1 commit into from

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Apr 11, 2023

Today we do not wait until the handshake is properly done on fetch and do not wait on WebSocket before call open event.

List of pending things:

@cirospaciari cirospaciari force-pushed the ciro/ws-fetch-proper-handshake branch from efb0e8a to e50ce69 Compare May 13, 2023 09:26
@github-actions
Copy link
Contributor

@cirospaciari 30 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/build.test.ts
  • test/bundler/bundler_browser.test.ts
  • test/bundler/bundler_edgecase.test.ts
  • test/bundler/bundler_jsx.test.ts
  • test/bundler/bundler_naming.test.ts
  • test/bundler/bundler_plugin.test.ts
  • test/bundler/bundler_string.test.ts
  • test/bundler/esbuild/dce.test.ts
  • test/bundler/esbuild/default.test.ts
  • test/bundler/esbuild/importstar.test.ts
  • test/bundler/esbuild/loader.test.ts
  • test/bundler/esbuild/splitting.test.ts
  • test/bundler/esbuild/ts.test.ts
  • test/bundler/esbuild/tsconfig.test.ts
  • test/cli/install/bun-add.test.ts
  • test/cli/install/bun-install.test.ts
  • test/cli/install/bunx.test.ts
  • test/cli/run/preload-test.test.js
  • test/js/bun/http/serve.test.ts
  • test/js/bun/plugin/plugins.test.ts
  • test/js/bun/resolve/png/test-png-import.test.js
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/test/preload-test.test.js
  • test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
  • test/js/bun/test/snapshot-tests/snapshots/more.test.ts
  • test/js/bun/util/sleepSync.test.ts
  • test/js/node/readline/readline.node.test.ts
  • test/js/web/fetch/fetch.test.ts
  • test/js/web/websocket/websocket.test.js
  • test/transpiler/transpiler.test.js

View test output

#43df22cead23065f993fe568b58cb537e2d5c731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant