support installation of NPM workspaces #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlamsl
force-pushed
the
npm-workspaces
branch
from
4afbd2b
to
630a6b3
Compare
alexlamsl
changed the title
|
|
||
| string_builder.count(key); | ||
| string_builder.count(value); | ||
| var workspace_file = try workspace_dir.openFile("package.json", .{ .mode = .read_only }); |
There was a problem hiding this comment.
can we do some kind of caching here to ensure we only open it once
- fix use-after-free on package names
alexlamsl
force-pushed
the
npm-workspaces
branch
from
95454b4
to
c933a28
Compare
alexlamsl
changed the title
alexlamsl
changed the title
alexlamsl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.