fix --print process.argv <args>
#17251
Open
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiskyMH
commented
Feb 11, 2025
RiskyMH
commented
Feb 11, 2025
test/cli/run/run-eval.test.ts
Outdated
Comment on lines
61
to
66
| const exe = isWindows ? bunExe().replace("/", "\\") : bunExe(); | ||
| testProcessArgv([], [exe]); | ||
| testProcessArgv(["abc", "def"], [exe, "abc", "def"]); | ||
| testProcessArgv(["--", "abc", "def"], [exe, "abc", "def"]); | ||
| // testProcessArgv(["--", "abc", "--", "def"], [exe, "abc", "--", "def"]); | ||
| }); |
There was a problem hiding this comment.
not sure why this last test doesn't work in Bun, but it is valid in node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
2 fixes:
--print, clap gets confused)/[eval]or/[stdin], then don't include it in argv, like nodefixes #12209, fixes #8381, fixes #17236
How did you verify your code works?
manually and made tests