Fix loading react-jsxdev instead of react-jsx #17013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3768
Fix loading react-jsxdev instead of react-jsx
The main bug: the state of the resolver sometimes got out of sync with the state of the transpiler for tracking if it should use development JSX or non-development JSX. This meant that setting
NODE_ENV
to a value in the parent process that is different than the environment seen from Bun.build would cause this to not work properly.Separately, I also implemented tracking
react-jsx
andreact-jsxdev
to work as expected.How did you verify your code works?
There is a test that runs each permutation of
NODE_ENV
for runtime and bundler.There is also a test for Bun.serve()
static