fix(node/assert): port more test cases from node

[DonIsaac]

What does this PR do?

Ports most remaining node:assert unit tests from node.

• test-assert-calltracker-getCalls
• test-assert-calltracker-calls
• test-assert-calltracker-report
• test-assert-calltracker-verify
• test-assert-checktag
• test-assert-esm-cjs-message-verify
• test-assert-fail
• test-assert-if-error
• test-assert-deep-with-error

Tests that still need to be ported are:

• test-assert-async
• test-assert-deep
• test-assert-fail-deprecation
• test-assert-first-line
• test-assert-objects
• test-assert-typedarray-deepequal

These require a good deal of refactoring and will be added in another PR.

How did you verify your code works?

There are tests.

[robobun]

^{Updated 4:44 PM PT - Feb 5th, 2025}

❌ @DonIsaac, your commit d8f51f6 has 2 failures in Build #11149:

• test/js/web/fetch/fetch.test.ts - 1 failing on 🍎 13 aarch64
• test/cli/install/bun-install-registry.test.ts - 1 failing on 🪟 2019 x64-baseline
• test/cli/install/bun-install-registry.test.ts - 1 failing on 🪟 2019 x64

---

🧪   try this PR locally:

bunx bun-pr 16895

[DonIsaac]

test-assert-checktag needs #16894 to land.

[dylan-conway]

Inside Bun__deepEquals when we are checking JSMapType equality we should have a RETURN_IF_EXCEPTION check after each Bun__deepEquals. Same with JSSetType. The other deep equals calls should be okay as they are because they immediately return on false

[dylan-conway]

Ah, that's now inside specialObjectsDequal

[DonIsaac]

It looks like Buffer instances use the same structure, class info, and JSType as the typed array they're constructed from. Since changing that is in a fully separate part of the codebase, I'll make that change in a follow-up pr.

[dylan-conway]

Left a few suggestions.

nit: the object equality code shouldn't be duplicated. Might be best to split it into template function with bool skipStackProp, but that can happen in a future pr

[DonIsaac]

@dylan-conway feel free to merge this PR whenever you're ready