Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .get() ignore Object.prototype instead of using getOwn #14322

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

This makes it so we never pay attention to Object.prototype when calling getters from Zig. This is a less restrictive mitigation for prototype pollution attacks compared to using getOwn.

How did you verify your code works?

The existing test for glob prototype pollution covers this

@Jarred-Sumner Jarred-Sumner merged commit a234e06 into main Oct 8, 2024
25 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/proto branch October 8, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants