Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-ts template #1036

Closed
wants to merge 21 commits into from
Closed

react-ts template #1036

wants to merge 21 commits into from

Conversation

DanielVain
Copy link

#967 adding the react typescript template

@github-actions github-actions bot added benchmarks needs tests Something that needs more testing labels Aug 9, 2022
@Jarred-Sumner
Copy link
Collaborator

Thanks for this

Please remove the unrelated changes and then happy to merge

@DanielVain
Copy link
Author

Thanks for this

Please remove the unrelated changes and then happy to merge

Unfortunately its just vscode doing these organization changes, ill try to revert.

@github-actions github-actions bot removed the needs tests Something that needs more testing label Aug 10, 2022
@DanielVain
Copy link
Author

@Jarred-Sumner there we go. changed it all back, all unrelated changes have been removed.

@@ -0,0 +1,9 @@
import React from 'react';
import { render, screen } from '@testing-library/react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to include tests it should be bun:test in the bun example :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to fix that. all i wanted to do is add the react typescript template. If anyone can help with this would be awesome.

// allows you to do things like:
// expect(element).toHaveTextContent(/react/i)
// learn more: https://github.com/testing-library/jest-dom
import '@testing-library/jest-dom';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work

@@ -0,0 +1 @@
/// <reference types="react-scripts" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct for bun

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be something different?

@Electroid
Copy link
Contributor

Thanks for working on this! Going to close this out now that we have a documentation website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants