-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-ts template #1036
react-ts template #1036
Conversation
Thanks for this Please remove the unrelated changes and then happy to merge |
Unfortunately its just vscode doing these organization changes, ill try to revert. |
@Jarred-Sumner there we go. changed it all back, all unrelated changes have been removed. |
@@ -0,0 +1,9 @@ | |||
import React from 'react'; | |||
import { render, screen } from '@testing-library/react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to include tests it should be bun:test
in the bun example :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to fix that. all i wanted to do is add the react typescript template. If anyone can help with this would be awesome.
examples/react-ts/src/setupTests.ts
Outdated
// allows you to do things like: | ||
// expect(element).toHaveTextContent(/react/i) | ||
// learn more: https://github.com/testing-library/jest-dom | ||
import '@testing-library/jest-dom'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work
@@ -0,0 +1 @@ | |||
/// <reference types="react-scripts" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct for bun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be something different?
Thanks for working on this! Going to close this out now that we have a documentation website. |
#967 adding the react typescript template