Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(socket) fix error in case of failure/returning a error in the open handler #10154

Merged
merged 11 commits into from
Apr 13, 2024

Conversation

cirospaciari
Copy link
Member

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Copy link
Contributor

github-actions bot commented Apr 10, 2024

@Jarred-Sumner
Copy link
Collaborator

I find it suspicious that the node-http2 tests fail

@Jarred-Sumner Jarred-Sumner merged commit f6b9c0c into main Apr 13, 2024
27 of 32 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-socket branch April 13, 2024 03:58
cirospaciari added a commit that referenced this pull request Apr 14, 2024
…n handler (#10154)

* fix socket

* one more test

* always clean callback on deinit

* Update src/bun.js/api/bun/socket.zig

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>

* make context close private

* keep old logic

* move clean step to SocketContext.close

* add comment

* wait for close on stop

* cleanup

---------

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants