Don't warn on moduleSuffixes when an empty string is passed (#16332)

oven-sh · Jan 12, 2025 · f9de8be · f9de8be
1 parent 2bc70df
commit f9de8be
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/resolver/tsconfig_json.zig b/src/resolver/tsconfig_json.zig
@@ -264,8 +264,18 @@ pub const TSConfigJSON = struct {
             }
 
             if (compiler_opts.expr.asProperty("moduleSuffixes")) |prefixes| {
-                if (!source.path.isNodeModule()) {
-                    log.addWarning(&source, prefixes.expr.loc, "moduleSuffixes is not supported yet") catch {};
+                if (!source.path.isNodeModule()) handle_module_prefixes: {
+                    var array = prefixes.expr.asArray() orelse break :handle_module_prefixes;
+                    while (array.next()) |*element| {
+                        if (element.asString(allocator)) |str| {
+                            if (str.len > 0) {
+                                // Only warn when there is actually content
+                                // Sometimes, people do "moduleSuffixes": [""]
+                                log.addWarning(&source, prefixes.loc, "moduleSuffixes is not supported yet") catch {};
+                                break :handle_module_prefixes;
+                            }
+                        }
+                    }
                 }
             }