Skip to content

Commit

Permalink
Default to "auto" instead of "us-east-1"
Browse files Browse the repository at this point in the history
  • Loading branch information
Jarred-Sumner committed Jan 4, 2025
1 parent e532456 commit 8a469cc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/s3.zig
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,8 @@ pub const AWSCredentials = struct {
}
}
}
return "us-east-1";

return "auto";
}
fn toHexChar(value: u8) !u8 {
return switch (value) {
Expand Down
4 changes: 2 additions & 2 deletions test/js/bun/s3/s3.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ describe.skipIf(!s3Options.accessKeyId)("s3", () => {
await s3file.write("Hello Bun!");
expect.unreachable();
} catch (e: any) {
expect(e?.code).toBe("InvalidAccessKeyId");
expect(e?.code).toBeOneOf(["FailedToOpenSocket", "ConnectionRefused"]);
}
}),
);
Expand All @@ -676,7 +676,7 @@ describe.skipIf(!s3Options.accessKeyId)("s3", () => {
await s3file.write("Hello Bun!");
expect.unreachable();
} catch (e: any) {
expect(e?.code).toBe("InvalidAccessKeyId");
expect(e?.code).toBeOneOf(["FailedToOpenSocket", "ConnectionRefused"]);
}
}),
);
Expand Down

0 comments on commit 8a469cc

Please sign in to comment.