Fixes #4020

oven-sh · Aug 7, 2023 · 04925bb · 04925bb
1 parent 3185ca2
commit 04925bb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/bunfig.zig b/src/bunfig.zig
@@ -253,23 +253,27 @@ pub const Bunfig = struct {
                             this.ctx.test_options.coverage.fractions.functions = expr.data.e_number.value;
                             this.ctx.test_options.coverage.fractions.lines = expr.data.e_number.value;
                             this.ctx.test_options.coverage.fractions.stmts = expr.data.e_number.value;
+                            this.ctx.test_options.coverage.fail_on_low_coverage = true;
                             break :outer;
                         }
 
                         try this.expect(expr, .e_object);
                         if (expr.get("functions")) |functions| {
                             try this.expect(functions, .e_number);
                             this.ctx.test_options.coverage.fractions.functions = functions.data.e_number.value;
+                            this.ctx.test_options.coverage.fail_on_low_coverage = true;
                         }
 
                         if (expr.get("lines")) |lines| {
                             try this.expect(lines, .e_number);
                             this.ctx.test_options.coverage.fractions.lines = lines.data.e_number.value;
+                            this.ctx.test_options.coverage.fail_on_low_coverage = true;
                         }
 
                         if (expr.get("statements")) |stmts| {
                             try this.expect(stmts, .e_number);
                             this.ctx.test_options.coverage.fractions.stmts = stmts.data.e_number.value;
+                            this.ctx.test_options.coverage.fail_on_low_coverage = true;
                         }
                     }
 

diff --git a/src/cli/test_command.zig b/src/cli/test_command.zig
@@ -557,6 +557,7 @@ pub const TestCommand = struct {
         fractions: bun.sourcemap.CoverageFraction = .{},
         ignore_sourcemap: bool = false,
         enabled: bool = false,
+        fail_on_low_coverage: bool = false,
     };
 
     pub fn exec(ctx: Command.Context) !void {
@@ -842,7 +843,7 @@ pub const TestCommand = struct {
             }
         }
 
-        if (reporter.summary.fail > 0 or (coverage.enabled and coverage.fractions.failing)) {
+        if (reporter.summary.fail > 0 or (coverage.enabled and coverage.fractions.failing and coverage.fail_on_low_coverage)) {
             Global.exit(1);
         }
     }