fix: fixing EINTR usage for early termination of waitforevent() #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthierry-ledger
added
api
pthierry-ledger
force-pushed
the
fix-wfe-intr
branch
from
9f0f6ef
to
b84a992
Compare
iartemov-ledger
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the wait_for_event() gate behaves is invalid, as it returns a STATUS_INTR when the syscall returns before its timeout definition when finding an input event.
The semantic of STATUS_INTR is not made for such a behavior, as it is made to requires from the caller to reexecute the syscall immediatly due to a interrupted function call (typically when a signal generated an interruption).
In our API, returning previously because there is input data should return a STATUS_OK instead.