Add ERC20 Premints

[ligustah]

Needed to use macros for a lot of things. The main problem is that we need to use separate namespaces for V2 and ERC20 ABI types, because we need to tweak the abi.json and change the names of some types. That's required for signatures to work correctly, but they can't both have the same names.

Experimented with a generic based solution, but ultimately went for the macros because of that.

[ligustah]

• Add ERC20 Premints #48 : 2 dependent PRs (#49 , #81 ) 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ligustah and the rest of your teammates on Graphite

[erikreppel]

I'm curious why so much of this needed to be macros?

[ligustah]

I'm curious why so much of this needed to be macros?

I tried going with generics first, but couldn't make it work. The underlying problem is that even though there is strong overlap between the two premints, it's hard to express that in generics. I was going with a generic shared zora premint type (similarly to what we have in the python version), but then ended up having to implement all data access through traits, which i then would need to implement for all new types. Also needed to put generic bounds all over the place, which to be honest I found much harder on the eyse than the macro. So I figured it's easier to just macro everything, since the function and field names are all the same, so it's basically copy&paste territory (for now).

If alloy supports aliasing types in the sol macro at some point we could come back and consolidate this a little more outside of the macros.

[ligustah]

Merge activity

• May 3, 3:03 PM EDT: @ligustah merged this pull request with Graphite.