Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Pytests Plots #1445

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[fix] Pytests Plots #1445

merged 3 commits into from
Oct 17, 2023

Conversation

SimonWittner
Copy link
Collaborator

🔬 Background

  • During testing some plots opened.

🔮 Key changes

  • Built-in plotting in conformal_predict disabled when running pytests.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1445 (f9d314c) into main (583e15b) will decrease coverage by 1.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
- Coverage   89.91%   88.32%   -1.59%     
==========================================
  Files          38       38              
  Lines        5097     5097              
==========================================
- Hits         4583     4502      -81     
- Misses        514      595      +81     

see 4 files with indirect coverage changes

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@ourownstory ourownstory merged commit a22a579 into ourownstory:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants